Update Contributing guide: Add more details to Debugging section #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add more concrete instruction for configuring backend - Explain what users should look for when changing `dev-test/index.html` - Add more info to use local storage to set Netlify site's URL
erezrokah
added
the
type: feature
erezrokah
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Thanks @bytrangle! Sorry for the late reply, I was out of office.
I'm back now (!) and will be going through issues and the rest of the PRs
|
Thank you @erezrokah . Please don't say sorry. You've always done a splendid job tidying up the PR section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I hope to make the Debugging section of the Contributing guide clearer to newbie contributors. Here is what I add:
dev-test/index.htmlTest plan
Checklist
Please add a
xinside each checkbox:yarn format.yarn test.A picture of a cute animal (not mandatory but encouraged)